-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EWPP-4825: Preview extension for file patterns. #1517
Conversation
5a63726
to
06285e6
Compare
@@ -18,6 +18,13 @@ file_translation: | |||
size: "150000" | |||
name: "document.pdf" | |||
language_code: "en" | |||
link_attributes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked and seems like it is possible to add extra_attributes for file_translation items as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is limited by the fact, that file_translation
has a different definition of the translations
property. It does not allow to pass any additional data along with the translated file (it just takes a list of FileValueObject
). So I can't pass the extra_attributes
too. To change it, i would have to refactor the pattern and all references to it.
EWPP-4825
Description
Modification of the patterns to support additional properties.